Replace deprecated datetime.utcnow() by datetime.now(timezone.utc) #979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
c00kiemon5ter
force-pushed
the
fix-deprecation
branch
from
92e5dca to
d045e79
Compare
Fixes: #934 Since Python 3.12, the utcnow function is deprecated. see, https://docs.python.org/3/library/datetime.html#datetime.datetime.utcnow This commit turns usages of `utcnow()` into `now(timezone.UTC)`. The solution is based on the suggestion from official Python docs: https://docs.python.org/3/library/datetime.html#datetime.datetime.utcnow Replace `datetime.datetime.utcnow()` with `datetime.datetime.now(datetime.timezone.utc)`. At the same time, the pytz dependency is removed in favour of the standard Python functions. Signed-off-by: Ivan Kanakarakis <[email protected]>
c00kiemon5ter
force-pushed
the
fix-deprecation
branch
from
d045e79 to
b3d4bc7
Compare
|
Thank you @bdrung ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #934
Description
Since Python 3.12, the
utcnowfunction is deprecated - see, https://docs.python.org/3/library/datetime.html#datetime.datetime.utcnowThis commit turns usages of
utcnow()intonow(UTC).The feature or problem addressed by this PR
This addresses the issue described in #934
What your changes do and why you chose this solution
The solution is based on the suggestion from official Python docs:
https://docs.python.org/3/library/datetime.html#datetime.datetime.utcnow
Replace
datetime.datetime.utcnow()withdatetime.datetime.now(datetime.timezone.utc).At the same time, the
pytzdependency is removed in favour of the standard Python functions.Checklist